Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

player-model/use new URL in subscribeSafariPromptPermission #1143

Merged
merged 1 commit into from
Nov 27, 2023
Merged

player-model/use new URL in subscribeSafariPromptPermission #1143

merged 1 commit into from
Nov 27, 2023

Conversation

fedterzi
Copy link
Contributor

@fedterzi fedterzi commented Nov 27, 2023 •
edited by jwilm
Loading

Description

1 Line Summary

use new URL with appId in subscribeSafariPromptPermission

Details

Due to changes in our API, the appId is now required in the URL used by subscribeSafariPromptPermission. In instances where the new URL is not usable, we fallback to the legacy URL with an additional request. This ensures compatibility with both the updated and legacy API endpoints.

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets

This change is Reviewable

@fedterzi
use new URL in subscribeSafariPromptPermission
5e056b9 
Due to changes in our API, the `appId` is now required in the URL
used by `subscribeSafariPromptPermission`. In instances where the new
URL is not usable, we fallback to the legacy URL with an additional
request. This ensures compatibility with both the updated and legacy
API endpoints.
@fedterzi fedterzi requested a review from jkasten2 November 27, 2023 20:05
@fedterzi fedterzi changed the title use new URL in subscribeSafariPromptPermission [Player-Model] use new URL in subscribeSafariPromptPermission Nov 27, 2023
@fedterzi fedterzi changed the title [Player-Model] use new URL in subscribeSafariPromptPermission player-model/use new URL in subscribeSafariPromptPermission Nov 27, 2023
@fedterzi fedterzi force-pushed the player-model/use_new_safari_subscription_url branch from f5c2e84 to 5e056b9 Compare November 27, 2023 20:26
@jkasten2 jkasten2 merged commit 7b3686f into player-model-main Nov 27, 2023
@jkasten2 jkasten2 deleted the player-model/use_new_safari_subscription_url branch November 27, 2023 20:35
@jkasten2 jkasten2 mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkasten2 jkasten2 jkasten2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedterzi @jkasten2