Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add missing import #1200

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[Fix] Add missing import #1200

merged 1 commit into from
Sep 30, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Sep 30, 2024

Description

1 Line Summary

Add missing NewRecordsState import

Details

Note: This fix was found after updating the release version to 160203 but before publishing the release.

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

Note: This fix was found after updating the release version to 160203 but before publishing the release.
@shepherd-l shepherd-l requested a review from jkasten2 September 30, 2024 20:34
@shepherd-l shepherd-l merged commit aa3c45b into main Sep 30, 2024
4 checks passed
@shepherd-l shepherd-l deleted the fix/newRecordsStateImport branch September 30, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants