-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
160205 release #1213
Merged
Merged
160205 release #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: volume mounting was incorrect. This led to `releases` directory on host not accurately reflecting contents in container. version property is deprecated
Motivation: get map files working no matter the environment. Works by updating the sourceMappingUrl comment in the output files
Motivation: control whether we override the server config for typical site by exposing a new user config param that overrides SW settings
Motivation: add coverage for new functionality, update default values for SW params
rgomezp
force-pushed
the
160205-release
branch
2 times, most recently
from
December 13, 2024 21:38
6e8cf75
to
fff1e5b
Compare
jkasten2
reviewed
Dec 13, 2024
workerName: undefined, | ||
registrationScope: undefined, | ||
customizationEnabled: true, | ||
customizationEnabled: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like customizationEnabled
is pre-existing dead code, so we could just clean this up instead of changing the value, since it has no effect anywhere.
jkasten2
approved these changes
Dec 13, 2024
Motivation: bump version
rgomezp
force-pushed
the
160205-release
branch
from
December 13, 2024 22:27
fff1e5b
to
4a7a8b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Add ability to override remote service worker config via new override param
serviceWorkerOverrideForTypical
.Details
Service Worker Configuration
Build & Environment Improvements
docker-compose.yml
releases
directory on the host accurately reflects the container contents.publish.sh
Release Version
160205
as part of the release process.Systems Affected
Validation
Tests
Added test coverage. Tested locally.
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of array
syntax. PreferforEach
or usemap
context
if possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.context
Screenshots
Info
Checklist
Related Tickets
This change is