Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

160205 release #1213

Merged
merged 8 commits into from
Dec 13, 2024
Merged

160205 release #1213

merged 8 commits into from
Dec 13, 2024

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Dec 13, 2024

Description

1 Line Summary

Add ability to override remote service worker config via new override param serviceWorkerOverrideForTypical.

Details

Service Worker Configuration

  • Introduced a new parameter, serviceWorkerOverrideForTypical, to allow users to override server settings for typical sites.

Build & Environment Improvements

docker-compose.yml

  • Fixed volume mounting issues to ensure the releases directory on the host accurately reflects the container contents.
  • Updated the version property, as the previous one was deprecated.

publish.sh

  • Modified the script to ensure sourceMappingUrl comments are correctly applied in output files, improving compatibility across environments.

Release Version

  • Updated the version to 160205 as part of the release process.

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Added test coverage. Tested locally.

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

Motivation: volume mounting was incorrect. This led to `releases` directory on host not accurately reflecting contents in container.

version property is deprecated
Motivation: get map files working no matter the environment.

Works by updating the sourceMappingUrl comment in the output files
Motivation: control whether we override the server config for typical site by exposing a new user config param that overrides SW settings
Motivation: add coverage for new functionality, update default values for SW params
@rgomezp rgomezp force-pushed the 160205-release branch 2 times, most recently from 6e8cf75 to fff1e5b Compare December 13, 2024 21:38
@rgomezp rgomezp requested a review from jkasten2 December 13, 2024 21:38
workerName: undefined,
registrationScope: undefined,
customizationEnabled: true,
customizationEnabled: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like customizationEnabled is pre-existing dead code, so we could just clean this up instead of changing the value, since it has no effect anywhere.

@rgomezp rgomezp merged commit d2409a1 into main Dec 13, 2024
4 checks passed
@rgomezp rgomezp deleted the 160205-release branch December 13, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants