TES-359: Fine tune role assignments #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailradkov
force-pushed
the
TES-359-role-assigments
branch
4 times, most recently
from
cccad56
to
7a36329
Compare
mihailradkov
commented
Nov 28, 2023
mihailradkov
force-pushed
the
TES-359-role-assigments
branch
from
7a36329
to
c48973b
Compare
mihailradkov
commented
Nov 29, 2023
The overhaul focuses on simplifying the module dependencies and responsibilities. - Vault and backup modules no longer depend on an identity - Added a new module rules dedicated for role assignments to anything required by the VMSS such as the key vault and backup storage account - Moved custom roles to the new roles module - Removed the storage account custom role in favor of directly providing the storage container in the user data script - Removed useless empty BLOB creation in the storage account - Optimized configurations role assignments for least privilege - Updated some comments/descriptions
mihailradkov
force-pushed
the
TES-359-role-assigments
branch
from
c48973b
to
4ba06d0
Compare
viktor-ribchev
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TES-359: Role assignments overhaul
The overhaul focuses on simplifying the module dependencies and responsibilities.