Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors&fixes #847

Merged
merged 10 commits into from
Oct 14, 2024
Merged

Refactors&fixes #847

merged 10 commits into from
Oct 14, 2024

Conversation

mmichal10
Copy link
Contributor

No description provided.

@mmichal10 mmichal10 marked this pull request as draft October 4, 2024 14:30
mmichal10 and others added 6 commits October 8, 2024 11:14
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
The fewer (atomic variable accesses on IO path) the better fare

Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Even if locking the new cache should never fail it's not an unrecoverable
state.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@mmichal10 mmichal10 force-pushed the pre-refcnt-fixes branch 2 times, most recently from 97426d2 to 1665af2 Compare October 8, 2024 09:20
@mmichal10 mmichal10 marked this pull request as ready for review October 8, 2024 09:21
example/simple/src/main.c Show resolved Hide resolved
src/mngt/ocf_mngt_cache.c Outdated Show resolved Hide resolved
The more (logging) the merrier

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
New caches are added to the list at the point where they are already
initialized and no errors are possible at this point, hence list_del() in error
handling is redundant.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@robertbaldyga robertbaldyga merged commit e5a2042 into Open-CAS:master Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants