-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle missing /etc/mtab and modify output #1514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deixx
force-pushed
the
mtab-check-optional
branch
7 times, most recently
from
September 12, 2024 13:22
b243149
to
3872fcc
Compare
Deixx
force-pushed
the
mtab-check-optional
branch
from
September 30, 2024 15:44
986bae1
to
626d549
Compare
Deixx
force-pushed
the
mtab-check-optional
branch
from
October 2, 2024 08:49
626d549
to
0bd5ad7
Compare
Deixx
force-pushed
the
mtab-check-optional
branch
from
October 16, 2024 13:00
0bd5ad7
to
86b8f24
Compare
mmichal10
previously approved these changes
Oct 21, 2024
Deixx
force-pushed
the
mtab-check-optional
branch
from
October 28, 2024 11:52
86b8f24
to
5600015
Compare
rafalste
reviewed
Oct 28, 2024
test/functional/tests/fault_injection/test_fault_injection_with_mounted_core.py
Show resolved
Hide resolved
mmichal10
previously approved these changes
Oct 28, 2024
There are situations when /etc/mtab is not present in the system (e.g. in certain container images). This blocks stop/remove operations. With making this check optional the duty of checking mounts falls to kernel. Test modified to check operations with and without mtab. Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
Calling functions now print error messages. All the mounted devices are printed (not just the first one). Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
Deixx
force-pushed
the
mtab-check-optional
branch
from
October 28, 2024 15:12
5600015
to
0c0b105
Compare
mmichal10
approved these changes
Oct 28, 2024
rafalste
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1515
Output after modifications: