tests: fix test_flush_over_640_gibibytes_with_fs #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mmichal10! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-10-03 10:53:57 UTC |
|
Requires Open-CAS/test-framework#18 |
mmichal10
force-pushed
the
fix-huge-test
branch
3 times, most recently
from
c5c62a5
to
3eb6443
Compare
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
The test requires quite some space(640G) to prepare a file on a separate (not-cached) filesystem. Creating the file in rootfs is prone to (vague) errors due to limited space. To make sure that the test has all the required space available, create the file on a separate disk Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
As crc32 is supposed to be slightly faster than md5 use it to detect DC Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
4h timeout for copying and calculating crc Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Don't interrupt the test if prerequisites are not met Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
fix-huge-test
branch
from
3eb6443
to
1ae15bd
Compare
Deixx
approved these changes
Oct 3, 2024
Kamoppl
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test requires quite some space(640G) to prepare a file on a separate (not-cached) filesystem. Creating the file in rootfs is prone to (vague) errors due to limited space.
To make sure that the test has all the required space available, create the file on a separate disk