Kamilg/speed up tf #1576
Open
Kamilg/speed up tf #1576
+178
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 30, 2024 01:00
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Deixx
requested changes
Oct 30, 2024
There was a problem hiding this comment.
I think this file belongs to some other PR ;)
| raise Exception(f"Test requires {required_duts} DUTs, only {len(duts)} DUT configs " | ||
| f"provided") | ||
| raise Exception( | ||
| f"Test requires {required_duts} DUTs, only {len(duts)} DUT configs " f"provided" |
| raise Exception(f"{ex}\n" | ||
| f"You need to specify DUT config. See the example_dut_config.py file") | ||
| raise Exception( | ||
| f"{ex}\n" f"You need to specify DUT config. See the example_dut_config.py file" |
| raise Exception(f"Exception occurred during test setup:\n" | ||
| f"{str(ex)}\n{traceback.format_exc()}") | ||
| raise Exception( | ||
| f"Exception occurred during test setup:\n" f"{str(ex)}\n{traceback.format_exc()}" |
Comment on lines
+175
to
+176
| raid.umount_all_partitions() | ||
| raid.remove_partitions() |
There was a problem hiding this comment.
Raid.remove_partitions() starts by calling self.unmount_all_partitions() - also it's unmount now, not umount
| raids = Raid.discover() | ||
| for raid in raids: | ||
| # stop only those RAIDs, which are comprised of test disks | ||
| test_run_disk_ids = {dev.device_id for dev in TestRun.disks.values()} |
| if filter(lambda dev: dev.device_id in test_run_disk_ids, raid.array_devices): | ||
| raid.umount_all_partitions() | ||
| raid.remove_partitions() | ||
| raid.stop() |
There was a problem hiding this comment.
reintroduced problem with raids, raid.unmount() is needed before stop
you basically reverted my recent fix for raid :/
Comment on lines
+36
to
39
| max_io_size_path = posixpath.join( | ||
| disk_utils.get_sysfs_path(core_device.device_id), "queue/max_sectors_kb" | ||
| ) | ||
| default_max_io_size = fs_utils.read_file(max_io_size_path) |
There was a problem hiding this comment.
I recommend get_sysfs_property("max_sectors_kb")
Comment on lines
+152
to
155
| path = posixpath.join(disk_utils.get_sysfs_path(dev_id), 'queue', c) | ||
| command = f"cat {path}" | ||
| output = TestRun.executor.run(command) | ||
| if output.exit_code == 0: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.