Add removal of old source package in installation test (#229)

* Add removal of old source package in installation test

tests/functional/test_package.py

@@ -100,6 +100,10 @@ def test_source_package_installation():
         with TestRun.step("Uninstall existing iotrace if needed"):
             uninstall_iotrace()
 
+    with TestRun.step("Remove old source package"):
+        TestRun.executor.run_expect_success(f"cd {work_path} && "
+                                            f"rm -rf iotrace-*-Source")
+
     with TestRun.step("Unpack and install source package"):
         TestRun.executor.run_expect_success(
             f"tar -xvf {work_path}/build/release/iotrace-*.tar.gz -C {work_path} &&"

tests/utils/dut.py

@@ -36,7 +36,9 @@ def dut_cleanup():
     TestRun.LOGGER.info("Stopping fuzzing")
     TestRun.executor.run(f'{iotrace.working_dir}/standalone-linux-io-tracer/tests/security/fuzzy/fuzz.sh clean')
 
-    iotrace.stop_tracing()
+    output = TestRun.executor.run('pgrep iotrace')
+    if output.stdout != "":
+        TestRun.executor.run(f'kill -2 {output.stdout}')
 
     TestRun.LOGGER.info("Removing existing traces")
     trace_repository_path: str = iotrace.get_trace_repository_path()

tests/utils/iotrace.py

@@ -176,7 +176,7 @@ def check_if_tracing_active(self) -> bool:
             TestRun.LOGGER.info("Iotrace processes not found.")
             return False
 
-        elif self.pid not in output.stdout:
+        elif self.pid is not None and self.pid not in output.stdout:
             TestRun.LOGGER.info(f"Found other iotrace process with PID {output.stdout}")
             return False
 

tests/utils/misc.py

@@ -10,4 +10,4 @@ def kill_all_io():
     TestRun.executor.run("pkill --signal SIGKILL dd")
     TestRun.executor.run(
         "kill -9 `ps aux | grep -i vdbench.* | awk '{ print $1 }'`")
-    TestRun.executor.run("pkill --signal SIGKILL fio*")
+    TestRun.executor.run("pkill --signal SIGKILL 'fio*'")