Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema unclear about Identifier field being string or array #12

Open
bluesteens opened this issue Jul 11, 2024 · 2 comments · May be fixed by #13
Open

schema unclear about Identifier field being string or array #12

bluesteens opened this issue Jul 11, 2024 · 2 comments · May be fixed by #13
Assignees
@S3bb1 @bluesteens
Labels
bug Something isn't working

Comments

@bluesteens
Copy link
Member

bluesteens commented Jul 11, 2024 •
edited
Loading

ATP Stakeholder credentials

Description suggests a single value in https://open-credentialing-initiative.github.io/schemas/specification/v1.2.0/#claim-subject-associated-identifier
and
Example gives one value at https://open-credentialing-initiative.github.io/schemas/specification/v1.2.0/#example-dscsa-atp-credential
BUT
Schema requires array in https://github.com/Open-Credentialing-Initiative/schemas/blob/main/credentials/DSCSAATPCredential-v1.0.0.jsonld
@bluesteens bluesteens converted this from a draft issue Jul 11, 2024
@bluesteens bluesteens self-assigned this Jul 11, 2024
@bluesteens bluesteens added the bug Something isn't working label Jul 11, 2024
@bluesteens bluesteens changed the title schema unclear about string or array schema unclear about Identifier field being string or array Jul 11, 2024
@bluesteens bluesteens moved this from P&A Triage Review & Consensus to 📋 Ready for work in OCI Change Management Jul 11, 2024
@bluesteens
Copy link
Member Author

P&A, 11 July 2024: remains OPTIONAL, array is intended

@bluesteens bluesteens linked a pull request Jul 17, 2024 that will close this issue
Fix: Subject Associated Identifier #13
Open
@bluesteens bluesteens moved this from 📋 Ready for work to 🏗 In progress in OCI Change Management Jul 17, 2024
@bluesteens bluesteens moved this from 🏗 In progress to 👀 P&A Completed Work Approval in OCI Change Management Aug 6, 2024
@alexcolganLD
Copy link
Contributor

Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@S3bb1 S3bb1

@bluesteens bluesteens

Labels
bug Something isn't working
Projects
OCI Change Management
Status: ✅ Done - Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Subject Associated Identifier Open-Credentialing-Initiative/schemas
3 participants
@S3bb1 @bluesteens @alexcolganLD