Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

237 best practices section #238

Merged
merged 19 commits into from
Oct 4, 2024
Merged

237 best practices section #238

merged 19 commits into from
Oct 4, 2024

Conversation

rwmcintosh
Copy link
Member

No description provided.

@rwmcintosh rwmcintosh marked this pull request as ready for review September 30, 2024 12:33
@rwmcintosh rwmcintosh marked this pull request as draft September 30, 2024 12:38
@rwmcintosh
Copy link
Member Author

@StephanSchaller FYI

@rwmcintosh
Copy link
Member Author

Still have a couple TODO to address. One link that was added here that doesn't work, but one that seems to be not working for some time.

Spell check and cross ref checks seem to be minimal, and are pointing to things that are actually not a problem

@rwmcintosh rwmcintosh marked this pull request as ready for review October 3, 2024 13:22
@rwmcintosh
Copy link
Member Author

All TODO's removed now, the checks all fail, but they are not true fails. Links work when clicked and spelling is fine for the words that trigger the failed test

@msevestre msevestre merged commit b2e260f into master Oct 4, 2024
0 of 3 checks passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephanSchaller The image has poor quality. Can we replace it with a one with better quality (ideally also SVG instead of PNG)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants