Optimize Code by Removing all Delays #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudharakaP
force-pushed
the
feat/removing-delay-calls
branch
from
c1fea1a to
04e4340
Compare
|
@yummyblabla : Okay this should do it I think. Removed all delay calls; this should make the execution faster; no more random delays. I've tested this as well. Will do some more tests and merge soon. 😸 |
|
From my current tests this cuts the execution time by half. From around 10 seconds to 5 seconds. 😉 |
SudharakaP
added a commit
that referenced
this pull request
Dec 15, 2023
SudharakaP
added a commit
that referenced
this pull request
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all delay calls and makes make the code in accordance with Puppeteer best practices.