Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about the timeframe for the 4 top widget of the dashboard #2123

Open
SamuelHassine opened this issue Dec 23, 2024 · 7 comments
Open
Labels
feature use for describing a new feature to develop

Comments

@SamuelHassine
Copy link
Member

SamuelHassine commented Dec 23, 2024

Description

Today we don't know that the 4 top widgets of the homepage retrive data on the last 180 days, we need to clarify this behavior to avoid the following type of confusion:

14 simulations:
Image

0 in dashboard:
Image

@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Dec 23, 2024
@SamuelHassine SamuelHassine changed the title Inaccurate number on customer instance Inaccurate number for simulations on customer instance Dec 23, 2024
@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Dec 23, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Dec 23, 2024
@EllynBsc EllynBsc added the regression Label to identify the bug as a regression of previously working feature label Dec 23, 2024
@guillaumejparis
Copy link
Member

To prevent performance issues, we currently limit fetching to the past 180 days for dashboard statistics.
To maintain performance while avoiding penalties for instances with no activity in the past six months, we could consider limiting the fetch to the last 100 simulations. wdyt @EllynBsc @jborozco ?

@guillaumejparis guillaumejparis self-assigned this Dec 24, 2024
@RomuDeuxfois
Copy link
Member

We can show to the user the limit taken -> 180 days.
Even if it means adding a date filter and leaving it up to the user to change it.

@EllynBsc
Copy link
Member

Hey @guillaumejparis @RomuDeuxfois 👋

As it is an edge case, I'd rather add some code than change the UI.
Could we add a condition like the following

 if there is no activity for the past six month
   fetch the last 100 simulations 

@RomuDeuxfois
Copy link
Member

@EllynBsc If we do that, we don't always have the same behavior on the same widget depending on the data we find. I find that a bit weird.

Note: all widgets are based on a time window.

@EllynBsc
Copy link
Member

@RomuDeuxfois good point. Ok then let's go for your solution:

  • We show the user the limit taken -> 180 days.
  • We add a date filter and let the user change it accordingly

@EllynBsc EllynBsc removed the regression Label to identify the bug as a regression of previously working feature label Dec 30, 2024
@EllynBsc
Copy link
Member

EllynBsc commented Jan 7, 2025

After discussion with @jborozco @RomuDeuxfois @guillaumejparis @Dimfacion, we'll focus on the first solution/workaround: display to the user that we show the activity < 180 days.

@EllynBsc EllynBsc added feature use for describing a new feature to develop and removed bug use for describing something not working as expected labels Jan 7, 2025
@EllynBsc EllynBsc modified the milestones: Bugs backlog, Release 1.11.0 Jan 7, 2025
@jborozco
Copy link

jborozco commented Jan 7, 2025

here is a mockup Image

@jborozco jborozco changed the title Inaccurate number for simulations on customer instance Add info about the timeframe for the 4 top widget of the dashboard Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop
Projects
None yet
Development

No branches or pull requests

5 participants