Injects bulk update allows to update irrelevant fields

[impolitepanda]

Description

Bulk update of injects always allow a user to add/replace/remove assets, asset groups, and teams, even if the selected injects are only of type email, for instance.

Environment

1. MacOS
2. OpenBAS version: 1.11.0 }
3. OpenBAS client: frontend

Reproducible Steps

Steps to create the smallest reproducible scenario:

1. Go to scenario -> Inject tabs
2. Either choose a scenario with at least 1 inject of type email or create one
3. Select at least 1 email type inject.
4. In the toolbar, click on the bulk update icon
5. Observe that you can still add/replace/remove assets and asset groups

Expected Output

To be defined:

• If only email type injects are selected, only allow for add/replace/remove of teams ?
• What if there are multiple types of injects, some which don't allow assets or asset groups, some other allowing it ?
• Warning on the fact that when using the "select all" feature, we don't have access to pages that are not loaded so we can't know on the client side if all selected elements are of a certain type or not unless a filter is set.

Actual Output

The bulk update window always allow updated of assets, asset groups or teams even if the type of inject don't allow it.
The update still works, and data is persisted in the DB, despite being useless.

Screenshots (optional)

[jborozco]

To be done:

• Make sure assets and asset groups are not updated in the DB for non-technical injects so the filtering system will not be impacted

Out of scope:

• Teams: we want to be able to assign teams for technical injects because we can add human response expectation to a technical inject in a simulation
• Form interaction: no need to block the behavior in the UI if the change doesn't have an impact on the DB