Remove black formatting/linting #126
Replies: 2 comments 2 replies
-
I don't think it's a good idea to get rid of an auto-formatter such as black. Passing black as a pre-commit hook will take the burden from the developer to pay attention to tiny aesthetics details and, more importantly, the code will always be formatted in the same way. I wouldn't remove it if I just find a line or two (from thousands) "ugly", which it is basically a personal opinion. Having a standard is more important than the standard being excellent. |
Beta Was this translation helpful? Give feedback.
-
I would also certainly not remove the auto formatter from the pre commit hooks. To improve performance, we can tweak the options somewhat (e. G. Slightly larger line length to match pylint, etc.). There are indeed some cases where edits made by black are marked as errors by pylint (import order in test binning is an example). |
Beta Was this translation helpful? Give feedback.
-
As mentioned by @steinnymir in the PR #118, the black formatting is sometimes very unpleasant and just explodes the lines in the code. Though, it has advantages in readability sometimes, many times it doesn't.
I'd propose we remove it from the pre commit hooks and just stick to linter definitions given in the github workflow.
Any suggestions are welcome @rettigl @daviddoji regarding linting and code formatting.
Beta Was this translation helpful? Give feedback.
All reactions