Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add typing, include versions in get_scan_path #290

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

swelborn
Copy link
Collaborator

improves on @ercius commit to enable getting scan path for new naming convention.

adds typing, and improves flow

Copy link
Collaborator

@ercius ercius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swelborn swelborn merged commit fc4253c into OpenChemistry:master Sep 4, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants