Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

WIP: Feature course registration #364

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

mahedee
Copy link
Contributor

@mahedee mahedee commented Apr 10, 2021

No description provided.

Copy link
Member

@ratanparai ratanparai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my review and fix those type of mistakes in rest of your PR. Thanks

docker-compose.dcproj Outdated Show resolved Hide resolved
docker-compose.override.yml Outdated Show resolved Hide resolved
eSchool.sln Outdated Show resolved Hide resolved
eSchool.sln Outdated Show resolved Hide resolved
eSchool.sln Outdated Show resolved Hide resolved
eSchool.sln Show resolved Hide resolved
src/ApiGateways/eSchool.GraphQL/Dockerfile Show resolved Hide resolved
@ratanparai
Copy link
Member

@mahedee: Please change the PR state to ready for review if you think your PR is ready for review

Screenshot 2021-04-16 at 8 59 25 PM

@mahedee mahedee marked this pull request as ready for review April 17, 2021 09:42

public async Task<bool> Handle(CourseRegistrationCommand command, CancellationToken cancellationToken)
{
var courseRegistration = new CourseRegistration.Domain.AggregatesModel.CourseRegistrationAggregate.CourseRegistration(command.CourseCode, command.CourseName, command.Description);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do one of choosing different aggregate root name or changing the service name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your suggestion for the name? We should follow a common convention.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahedee: We have decided use suffix Service for namespace. So the namespace of this class will be CourseRegistrationService.API.Application.Commands. This way we can create the Aggregate with the name CourseRegistration without any issue.

@ratanparai
Copy link
Member

ratanparai commented Apr 17, 2021

@mahedee As the PR is very big, I will try to complete the review in multiple small reviews.

Alternatively, you can also break the PR into multiple small PRs too.

After resolving current issues, we will move forward with pending files.


public async Task<bool> Handle(CourseRegistrationCommand command, CancellationToken cancellationToken)
{
var courseRegistration = new CourseRegistration.Domain.AggregatesModel.CourseRegistrationAggregate.CourseRegistration(command.CourseCode, command.CourseName, command.Description);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahedee: We have decided use suffix Service for namespace. So the namespace of this class will be CourseRegistrationService.API.Application.Commands. This way we can create the Aggregate with the name CourseRegistration without any issue.

@ratanparai ratanparai linked an issue Oct 2, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial implementation of Course registration service
2 participants