This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Feature course registration #364
base: main
Are you sure you want to change the base?
WIP: Feature course registration #364
Changes from 11 commits
a4e82df
53c7176
155d120
940fc6b
16a1b49
eaf4ba2
b891d74
d0ce04f
69e6248
2c7c8cd
f9b0673
b326a7a
5f8de23
233a1e7
ecd5754
ba4acd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do one of choosing different aggregate root name or changing the service name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is your suggestion for the name? We should follow a common convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahedee: We have decided use suffix
Service
for namespace. So the namespace of this class will beCourseRegistrationService.API.Application.Commands
. This way we can create the Aggregate with the nameCourseRegistration
without any issue.