Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated AnalyzeTemporaryDtors #55

Merged
merged 3 commits into from
May 6, 2024
Merged

remove deprecated AnalyzeTemporaryDtors #55

merged 3 commits into from
May 6, 2024

Conversation

serges147
Copy link
Contributor

No description provided.

@serges147 serges147 self-assigned this May 6, 2024
@serges147 serges147 requested a review from pavel-kirienko May 6, 2024 11:58
Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but now Sonar is failing because we're running an old version of Java. The fix is simple: pavel-kirienko/o1heap@10e2754#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R62-R66

Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@serges147 serges147 requested a review from pavel-kirienko May 6, 2024 14:05
@serges147
Copy link
Contributor Author

@pavel-kirienko now it's green

@serges147 serges147 merged commit 6c7c12e into main May 6, 2024
23 checks passed
@serges147 serges147 deleted the sshirokov/main branch May 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants