gh-pages: Fix scenario titles by using scenario.title[page.lang] #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit bdb5170, docs/_data/dsra.yml was restructured where scenario.title was changed from an English string to two children nodes of "en" and "fr" to accommodate the French titles. However, I failed to replace scenario.title with scenario.title[page.lang] in the Markdown files accordingly, leading to strange display of scenario titles such as {"en"=>"M7.1 Sidney (BC)", "fr"=>"M7,1 à Sidney (C.-B.)"}, for example. Fixes OpenDRR#84
anthonyfok
force-pushed
the
fix-scenario-title-page-lang
branch
from
5cccba6
to
770a42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit bdb5170, docs/_data/dsra.yml was restructured where scenario.title was changed from an English string to two children nodes of
enandfrto accommodate the French titles.However, I failed to replace
scenario.titlewithscenario.title[page.lang]in the Markdown files accordingly, leading to strange display of scenario titles such as {"en"=>"M7.1 Sidney (BC)", "fr"=>"M7,1 à Sidney (C.-B.)"}, for example.Also reverted to not adding indentation to lists in docs/_data/dsra.yml, matching the formatting found in Damon’s original version and on https://yaml.org/.
Fixes #84