Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an AppendNoPush optimization #2057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add an AppendNoPush optimization #2057

wants to merge 1 commit into from
+69 −1

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Oct 22, 2024

There are ~10.5k usages of Append in Paradise bytecode. Of these, all but ~160 immediately pop the value that Append pushes to the stack.

This adds a simple AppendNoPush peephole opt and opcode, with identical behavior except the opcode handler does not push the result to the stack.

@boring-cyborg boring-cyborg bot added Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ike709