Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index storage registry events and refactor events code #6

Merged
merged 1 commit into from
Dec 26, 2023
Merged

index storage registry events and refactor events code #6

merged 1 commit into from
Dec 26, 2023

Conversation

avichalp
Copy link
Collaborator

  • Adds event listeners for Storage Registry contract
  • Flesh out most of Key Registry event logic.
  • Refactor the current events code to abstract out various reusable parts

@avichalp
index storage registry events and refactor events code
96f6e2d 
Signed-off-by: avichalp <hi@avichalp.me>
haardikk21
haardikk21 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@haardikk21 haardikk21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, still a couple of TODOs here but I think they require schema changes and can be addressed later

@haardikk21 haardikk21 merged commit 68dfb10 into OpenFarcaster:main Dec 26, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haardikk21 haardikk21 haardikk21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avichalp @haardikk21