Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salesforce: docs deep dive #664

Open
josephjclark opened this issue Jul 4, 2024 · 8 comments
Open

salesforce: docs deep dive #664

josephjclark opened this issue Jul 4, 2024 · 8 comments
Assignees

Comments

@josephjclark
Copy link
Collaborator

josephjclark commented Jul 4, 2024

This issue is to do a deep docs review on Salesforce. I expect to contribute heavily to this myself.
good examples

Requirements:

  • state mutation JSdocs
  • careful consistent language
  • http helpers must explicitly clearly target salesforce
  • update, create and upsert example supports multiple records
  • bulk upsert example
  • Example for each supported bulk operation
  • Ensure examples are clear, concise, and demonstrate best practices.
@github-project-automation github-project-automation bot moved this to New Issues in v2 Jul 4, 2024
@mtuchi
Copy link
Collaborator

mtuchi commented Jul 19, 2024

I won't be able to work on this issue this week, We should probably promote to next week sprint

@aleksa-krolls aleksa-krolls moved this from New Issues to Ready in v2 Jul 19, 2024
@aleksa-krolls aleksa-krolls moved this from Ready to Backlog in v2 Jul 19, 2024
@mtuchi
Copy link
Collaborator

mtuchi commented Aug 5, 2024

@aleksa-krolls this issue

@mtuchi
Copy link
Collaborator

mtuchi commented Oct 10, 2024

@josephjclark i need second opinion, is this a good first issue for salesforce adaptor ?. I am curios if we should start with #663 ?

@josephjclark
Copy link
Collaborator Author

@mtuchi We need a good round of documentation and unit tests before we port the jsforce version. The idea is to have a stable base to migrate from. It may help catch issues in the library.

So an ideal start is to go through and make sure docs are a) complete and b) accurate. That doesn't mean hundreds of words - it means links to salesforce or jsforce documentation, it means state tables and maybe object definitions, it means concise and helpful examples.

@mtuchi mtuchi linked a pull request Oct 25, 2024 that will close this issue
12 tasks
@mtuchi mtuchi mentioned this issue Oct 25, 2024
12 tasks
@mtuchi
Copy link
Collaborator

mtuchi commented Oct 25, 2024

EOD Update #799
Unit test are failing because of @state tag. Joe is helping me investigating

@aleksa-krolls
Copy link
Member

Hey @mtuchi what is status here? Pls leave EOD updates... especially on Friday!

Also, if there is work left here - pls make sure to prioritize client work before picking this back up.

@mtuchi
Copy link
Collaborator

mtuchi commented Nov 11, 2024

I have a draft PR already i just need to clean up and ask Joe for review, I will pick this up tomorrow

@mtuchi
Copy link
Collaborator

mtuchi commented Nov 12, 2024

EOD Update

This is done and ready for review, See #821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants