Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Salesforce next #691

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Epic: Salesforce next #691

wants to merge 14 commits into from

Conversation

josephjclark
Copy link
Collaborator

@josephjclark josephjclark commented Jul 23, 2024

Epic PR to track Salesforce changes

@josephjclark
Copy link
Collaborator Author

Important: common 2.0 will be released before this, which exports a new http namespace. We'll need to take care to include and document that change here.

@josephjclark
Copy link
Collaborator Author

@mtuchi this PR needs to be merged (or rebased maybe) with main. Merging is probably easier.

@mtuchi
Copy link
Collaborator

mtuchi commented Aug 1, 2024

Okay let me look at git conflict

@mtuchi
Copy link
Collaborator

mtuchi commented Aug 1, 2024

@josephjclark i have fixed the git conflicts, please review and proceed

@josephjclark
Copy link
Collaborator Author

@mtuchi Thank you!

@josephjclark
Copy link
Collaborator Author

In this PR, can we move toUTF8 to the utils namespace?

@josephjclark
Copy link
Collaborator Author

Something else we might think about is that retrieve and get are pretty confusing!

Whose language is retrieve? Is it ours?

Maybe we should think about getRecords instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants