Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn v4.3.1 #507

Closed
wants to merge 3 commits into from
Closed

Yarn v4.3.1 #507

wants to merge 3 commits into from

Conversation

josephjclark
Copy link
Contributor

@josephjclark josephjclark commented Jun 21, 2024

Turns out yarn has its own self-versioning strategy now - it should really be locked to the project

I am not quite sure why, then, I was on v1. Maybe I'd missed some setup? I've just updated ubuntu, maybe that did something.

QA notes

Can we run some quick QA on this?

  • checkout this branch
  • run yarn install
  • should be no diffs in yarn.lock
  • yarn -v should print 4.3.1?

Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack!

image image

@josephjclark
Copy link
Contributor Author

When I check out this branch my yarn version immediately changes to 4.3.1.

So I'm not sure why you're on 3.2.3 🤔

Have you run corepack enable @taylordowns2000 ? Does that make any difference?

@taylordowns2000
Copy link
Member

just tried with corepack enable first and no luck. same diff (and same yarn version.)

i use asdf, would that impact?

@josephjclark
Copy link
Contributor Author

I'm using asdf too. But yeah it might be a factor. I don't know if an install or reshim makes a difference?

Frustrating issue. I don't care which version we use but I want all developers to be using the same yarn. Which should Just Work ™️

I'll run a couple of tests on a second system this afternoon

@aleksa-krolls
Copy link
Member

hey @josephjclark what's the status here?

@josephjclark
Copy link
Contributor Author

Hey, yeah this is an annoying one. I need to work out how to synchronise yarn versions properly and I'm not even sure how to approach it.

For most docs work it doesn't matter, but any work that touches the yarn lockfile is hard to merge at the moment.

I'll give this some time today.

@josephjclark
Copy link
Contributor Author

This and #506 are closely related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants