Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather should support simulation repeats submitted in parallel #987

Closed
atravitz opened this issue Oct 28, 2024 · 1 comment · Fixed by #1044
Closed

gather should support simulation repeats submitted in parallel #987

atravitz opened this issue Oct 28, 2024 · 1 comment · Fixed by #1044
Assignees
Labels
cli command-line interface priority:high

Comments

@atravitz
Copy link
Contributor

atravitz commented Oct 28, 2024

When running quickrun in parallel, the directory structure changes so to be results_0/, results_1/, results_2/ , and gather no longer works

We need to decide if gather should support this scenario, or if we need to be more strict about user-behavior.

@atravitz atravitz added the cli command-line interface label Oct 28, 2024
@CurtisColwell
Copy link

CurtisColwell commented Oct 29, 2024

Glad this is already here. I am running into this problem now. I changed the protocol_repeats to 1 to run each repeat separately, but it doesn't add to the currently existing .json output. Can I add the new 'protocol_result' and 'unit_results' or will this not work?

A nice solution would be adding the new repeat to the old output file instead of throwing this error:

Error: Invalid value for '-o': File 'results/easy_rbfe_mol1_solvent_mol2_solvent.json' already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli command-line interface priority:high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants