fix issue #1042 and also test openfecli for API breaks

[mikemhenry]

Checklist

• Added a news entry

Developers certificate of origin

• I certify that this contribution is covered by the MIT License here and the Developer Certificate of Origin at https://developercertificate.org/.

Fixes #1042

[github-actions]

🚨 API breaking changes detected! 🚨

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (8374172) to head (42defe0).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   92.84%   92.81%   -0.03%     
==========================================
  Files         134      134              
  Lines       10003    10003              
==========================================
- Hits         9287     9284       -3     
- Misses        716      719       +3     

Flag	Coverage Δ
fast-tests	92.81% <ø> (?)
slow-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[mikemhenry]

Okay, so now I will add an api break and see if we get the new message

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[mikemhenry]

Okay that worked!

URL takes you here: https://github.com/OpenFreeEnergy/openfe/actions/runs/12321768691#step:check

which isn't perfect but I am not sure if I can use a url to get us here:

[mikemhenry]

Now I will "fix" that change and lets see if it deletes the old comment

[github-actions]

🚨 API breaking changes detected! 🚨

[mikemhenry]

Ah, if there is no failure then it doesn't delete the comment, will fix that now

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[mikemhenry]

Sweet, it deleted the comment. I will do one more cycle of testing and then I think we will be good to go

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

No API break detected ✅

[mikemhenry]

okay it had the break, now lets see if it deletes this comment and says things are fine

[mikemhenry]

cool, it works!

[github-actions]

🚨 API breaking changes detected! 🚨

[mikemhenry]

To test it I had to switch it to run on pull_request but that means the old version with pull_request_target would also run, so its cluttered with old bot messages, but I posted screenshots of the tests where it worked. To truly test it, we will just need to merge it and see how it behaves, but I did test it as much as I could.

[atravitz]

lgtm, let's merge!