Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set navigation_keys to False to avoid warning #584

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 25, 2023

I think this warning is causing builds to fail, either way we should just define it.

Developers certificate of origin

@IAlibay
Copy link
Member Author

IAlibay commented Oct 25, 2023

Relevant pydata-sphinx-theme commit: pydata/pydata-sphinx-theme@36847fc

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a5d4b8) 92.03% compared to head (058db74) 92.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         123      123           
  Lines        8157     8157           
=======================================
  Hits         7507     7507           
  Misses        650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay enabled auto-merge October 25, 2023 08:14
@IAlibay IAlibay merged commit bb49f83 into main Oct 25, 2023
8 checks passed
@IAlibay IAlibay deleted the fix-nav-keys branch October 25, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants