Skip to content

Developer's notes

nkrah edited this page Nov 9, 2023 · 32 revisions

Current (priority)

  • (now): Volume refactoring
  • (todo next): Simulation as a json file

Next steps:

  • visualisation of voxelized volume with 3D slices
  • Refactor sources
  • Refactor actors
  • Consolidate: Simulation user API and rename geometry_manager
  • Retrieving repeated volumes of detailed information (position etc), once built. Important for PET design
  • Consolidate subprocess system: handle subprocessing in Simulation class (rather than engine)

Consolidate refactored volumes

  • remove unnecessary warning in RepeatParametrisedVolume (issue #279)
  • in ImageVolume: dump also sorted LUT if a label image is requested so the user can associate labels and materials.
  • option in ImageVolume to assign origin and rotation in an inout image as translation and rotation to the ImageVolume object
  • Check and improve RepeatParametrisedVolume
  • The repeat_ring helper function is somewhat unintuitive, in particular the translation parameter which is applied to the first repetition. Would it not be more intuitive to define the ring's center and the distance to the rotation axis?
  • The "translation" parameter in the context of repeated volumes should be renamed because it interferes with the common parameter "translation" of volumes. Something like "spacing" would be better I think.
  • Similarly, the "offset" and "offset_nb" parameters are strange. In my understanding, this is more like a nested repetition, or block repetition. In that case, the name might be revisited. To be checked.
Clone this wiki locally