Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23.0.0.8 staging #3264

Merged
merged 34 commits into from
Aug 18, 2023
Merged

23.0.0.8 staging #3264

merged 34 commits into from
Aug 18, 2023

Conversation

@lauracowen lauracowen requested review from dmuelle and removed request for dmuelle August 18, 2023 09:48
ayoho
ayoho previously approved these changes Aug 18, 2023
@lauracowen lauracowen requested review from mbroz2 and removed request for mbroz2 August 18, 2023 12:01
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
Azquelt
Azquelt previously approved these changes Aug 18, 2023
Copy link
Member

@mbroz2 mbroz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments are pretty minor; overall looks good.
'Expected behavior' comment applies to all the listed bugs.

posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
Co-authored-by: mbroz2 <mbroz@us.ibm.com>
@lauracowen lauracowen dismissed stale reviews from Azquelt and ayoho via b83b828 August 18, 2023 13:05
Co-authored-by: mbroz2 <mbroz@us.ibm.com>
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID review- has the format for bug fixes changed? To me, the "Expected behavior" template seems equivocal about what's been fixed. But if it's a common format that isn't likely to confuse others, ok

posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
lauracowen and others added 5 commits August 18, 2023 16:17
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
gkwan-ibm
gkwan-ibm previously approved these changes Aug 18, 2023
Copy link
Member

@gkwan-ibm gkwan-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the guides section

posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
posts/2023-08-22-23.0.0.8.adoc Outdated Show resolved Hide resolved
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmuelle dmuelle merged commit 3dccd48 into staging Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants