-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc page about the CDI Extension SPI #7525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @benjamin-confino
Hi @benjamin-confino - I changed the base to For details about the OL topic writing/publishing process, see Publishing a new topic in the readme. Thanks! |
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
@dmuelle I've opened the issue as requested, and you are correct to assume this goes under Context and Dependency Injection |
9994aba
to
1d6f32a
Compare
modules/ROOT/nav.adoc
Outdated
@@ -37,6 +37,7 @@ | |||
* xref:cdi-beans.adoc[Context and Dependency Injection] | |||
** xref:jaxrs-integration-cdi.adoc[RESTful Web Services integration with CDI] | |||
** https://openliberty.io/guides/cdi-intro.html[Guide: Injecting dependencies into microservices] | |||
** xref:cdi-extension-user-feature.adoc[Creating a CDI Extension inside a User Feature] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid branch conflicts between draft-staging-production, we only update the nav file from a dedicated branch:
https://github.com/OpenLiberty/docs?tab=readme-ov-file#editing-the-docs-navigation
I went ahead and added this entry from the draft-nav
branch in #7532
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I thought "They can work with you to determine the best section of the navigation for your topic and to update the nav.adoc file." meant it went into this branch. I've pulled that out of the PR
1d6f32a
to
2b20373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This creates a simple page that goes through implementing CDIExtensionMetadata, it links to a pre-existing blogpost to give a step by step guide to creating a user feature that uses CDIExtensionMetadata