Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/st dataframe pagenation #77
Add/st dataframe pagenation #77
Changes from 3 commits
0a8bc3b
f3dad89
ba99afc
fcc2be2
d73ce80
085ba0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be more flexible as the data displayed may vary. I think adding
column_order
as a function parameter would work best. Is there a reason whyselection_mode
,on_select
,use_container_width
, andhide_index
have to be set to these specific values? If not I would suggest adding those as parameters as well.Anything specific to a particular workflow/dataset should not be located in
common.py
as it is intended to contain functions of general use. As a sidenote, common modules should be moved in a separate directory to make this more clear to developers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. These are specifically set because I came across this issue when using the pyopenms workflow for selecting spectra to plot when selecting a row, but this should be more flexible for other use cases.
We could pass
kwargs
to thedisplay_large_dataframe
method forst.dataframe
because that's probably the only main method that would need to be changed based on particular needs. I opted for this option