OPG-488: Fix issue with Performance query variable interpolation

[synqotik]

If you add 2 variables to a Dashboard and they both have the same beginning of the variable name, then if you use the one with the longer name in a Performance query, the variable interpolation will end up doing a partial match on the shorter variable name and doing the interpolation, adding the rest of the longer variable name onto the value.

Example: user adds $node and $nodeId variables, both referencing nodeFilter(), maybe $node actually references nodeFilter(labelFormat=id:label,valueFormat=id).

User uses $nodeId in a Performance Attribute query for the Node. They then try to set the Resource part of the query but it fails. Say $node and $nodeId were both set to a node Id of 1. Interpolation finds $node, does a substitution on the string $nodeId and results in 1Id. This is sent to the query to get resources and fails (node[1Id] is not found).

Solution is to add a word boundary to the regex before doing a replacement, e.g. do a regex match on \$node\b will fail on a string $nodeId; \$nodeId\b will correctly match.

External References

• JIRA (Issue Tracker): https://opennms.atlassian.net/browse/OPG-488
• Continuous Integration: CircleCI

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[christianpape]

LGTM.