Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-16477: Replace babel/polyfill with corejs3 (foundation-2021) #7386

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

synqotik
Copy link
Contributor

@synqotik synqotik commented Aug 5, 2024

@babel/polyfill was deprecated and replaced with core-js@3 back in 2020.

polyfill has some security vulnerabilities. We upgraded to core-js 3 first in develop, this is to update foundation-2021.

Update 10/29/2024: We've tested this on foundation-2021 and have not found any issues, so we will merge.

External References

@synqotik synqotik force-pushed the jira/NMS-16477-replace-babel-polyfill branch from 328f64e to cb637ae Compare August 5, 2024 19:59
@synqotik synqotik force-pushed the jira/NMS-16477-replace-babel-polyfill branch from 79814f6 to de6f82d Compare August 19, 2024 17:28
@synqotik synqotik force-pushed the jira/NMS-16477-replace-babel-polyfill branch 2 times, most recently from 0b8019a to 53a0813 Compare September 11, 2024 20:28
@synqotik synqotik force-pushed the jira/NMS-16477-replace-babel-polyfill branch from cb43985 to e73dad9 Compare September 12, 2024 19:02
@synqotik synqotik marked this pull request as ready for review October 29, 2024 13:43
Copy link
Contributor

@faizanjanjua faizanjanjua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .

@synqotik synqotik merged commit 4da1d2d into foundation-2021 Oct 29, 2024
8 checks passed
@synqotik synqotik deleted the jira/NMS-16477-replace-babel-polyfill branch October 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants