Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc: -d needs to be added for cUrl to function adequately #7403

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

vasc0x
Copy link
Contributor

@vasc0x vasc0x commented Sep 1, 2024

All Contributors

Contribution Checklist

  • Please make an issue in the OpenNMS issue tracker if there isn't one already.
    Once there is an issue, please:
    1. update the title of this PR to be in the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the Jira link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
    4. once you've created this PR, please link to it in a comment in the Jira issue
      Don't worry if this sounds like a lot, we can help you get things set up properly.
  • If this code is likely to affect the UI, did you name your branch with -smoke in it to trigger smoke tests?
  • If this is a new or updated feature, is there documentation for the new behavior?
  • If this is new code, are there unit and/or integration tests?
  • If this PR targets a foundation-* branch, does it try to avoid changing files in $OPENNMS_HOME/etc/?

What's Next?

A PR should be assigned at least 2 reviewers. If you know that someone would be a good person to review your code, feel free to add them.

If you need help making additions or changes to the documentation related to your changes, please let us know.

In any case, if anything is unclear or you want help getting your PR ready for merge, please don't hesitate to say something in the comments here,
or in the #opennms-development chat channel.

Once reviewer(s) accept the PR and the branch passes continuous integration, the PR is eligible for merge.

At that time, if you have commit access (are an OpenNMS Group employee or a member of the OGP) you are welcome to merge the PR when you're ready.
Otherwise, a reviewer can merge it for you.

Thanks for taking time to contribute!

External References

@github-actions github-actions bot added the docs label Sep 1, 2024
@dino2gnt dino2gnt requested review from dino2gnt and removed request for dino2gnt September 14, 2024 01:28
@dino2gnt
Copy link
Contributor

Not sure what this master-33 represents. This should target develop or, alternately, one of the foundation-* branches.

@indigo423 indigo423 changed the base branch from master-33 to foundation-2021 September 23, 2024 09:42
@indigo423 indigo423 changed the base branch from foundation-2021 to develop September 23, 2024 09:43
dino2gnt
dino2gnt previously approved these changes Sep 23, 2024
Copy link
Contributor

@dino2gnt dino2gnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@cgorantla cgorantla changed the base branch from develop to foundation-2023 September 24, 2024 17:37
@cgorantla cgorantla dismissed dino2gnt’s stale review September 24, 2024 17:37

The base branch was changed.

@cgorantla cgorantla changed the base branch from foundation-2023 to release-33.x September 24, 2024 17:38
@cgorantla cgorantla changed the base branch from release-33.x to develop September 24, 2024 17:40
@cgorantla cgorantla changed the title -d needs to be added for cUrl to function adequately Fix doc: -d needs to be added for cUrl to function adequately Sep 24, 2024
@cgorantla cgorantla merged commit 8e79458 into OpenNMS:develop Sep 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants