Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create advanced-alarm-handling.adoc #7426

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

marshallmassengill
Copy link
Contributor

Adding a page for examples of advanced alarm handling with drools.

All Contributors

Contribution Checklist

  • Please make an issue in the OpenNMS issue tracker if there isn't one already.
    Once there is an issue, please:
    1. update the title of this PR to be in the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the Jira link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
    4. once you've created this PR, please link to it in a comment in the Jira issue
      Don't worry if this sounds like a lot, we can help you get things set up properly.
  • If this code is likely to affect the UI, did you name your branch with -smoke in it to trigger smoke tests?
  • If this is a new or updated feature, is there documentation for the new behavior?
  • If this is new code, are there unit and/or integration tests?
  • If this PR targets a foundation-* branch, does it try to avoid changing files in $OPENNMS_HOME/etc/?

What's Next?

A PR should be assigned at least 2 reviewers. If you know that someone would be a good person to review your code, feel free to add them.

If you need help making additions or changes to the documentation related to your changes, please let us know.

In any case, if anything is unclear or you want help getting your PR ready for merge, please don't hesitate to say something in the comments here,
or in the #opennms-development chat channel.

Once reviewer(s) accept the PR and the branch passes continuous integration, the PR is eligible for merge.

At that time, if you have commit access (are an OpenNMS Group employee or a member of the OGP) you are welcome to merge the PR when you're ready.
Otherwise, a reviewer can merge it for you.

Thanks for taking time to contribute!

External References

Adding a page for examples of advanced alarm handling with drools.
@github-actions github-actions bot added the docs label Sep 13, 2024
Copy link
Contributor

@dino2gnt dino2gnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great start.

…andling.adoc

Co-authored-by: Dino <dyancey@opennms.com>
…andling.adoc

Co-authored-by: Dino <dyancey@opennms.com>
@dino2gnt
Copy link
Contributor

What is this master-33 branch this is targeting? That should be ... something else, I think.

@marshallmassengill
Copy link
Contributor Author

What is this master-33 branch this is targeting? That should be ... something else, I think.

Ugh... yeah... will resolve that tomorrow.

@marshallmassengill marshallmassengill marked this pull request as draft September 14, 2024 20:16
@marshallmassengill marshallmassengill changed the base branch from master-33 to develop September 14, 2024 20:17
@marshallmassengill marshallmassengill marked this pull request as ready for review September 14, 2024 20:17
@cgorantla
Copy link
Contributor

@marshallmassengill you may have to merge latest develop into your branch to make the circleci pass the builds

@marshallmassengill
Copy link
Contributor Author

@marshallmassengill you may have to merge latest develop into your branch to make the circleci pass the builds

I think I've done that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants