Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-16510 : Search does not return any results for Asset Search strin… #7509

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

Junaid-Khan-Nant
Copy link
Contributor

Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case either in integration or smoke tests.

cgorantla
cgorantla previously approved these changes Nov 1, 2024
Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also validate if all other asset related fields have right names in the Restrictions.

@Junaid-Khan-Nant
Copy link
Contributor Author

Hi @cgorantla, All restrictions are checked; it seems fine except one that's maintContractExpires. But it is also working fine as we get value from getter; in that case, a screenshot is attached for reference. Don't need to change in it, I believe.
Screenshot from 2024-11-04 16-10-19

Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Junaid-Khan-Nant Junaid-Khan-Nant merged commit 88f7845 into foundation-2024 Nov 4, 2024
17 checks passed
@Junaid-Khan-Nant Junaid-Khan-Nant deleted the jk/jira/NMS-16510 branch November 4, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants