Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions for running tests #14

Merged
merged 7 commits into from
Mar 11, 2021
Merged

Add github actions for running tests #14

merged 7 commits into from
Mar 11, 2021

Conversation

cutz
Copy link
Contributor

@cutz cutz commented Mar 5, 2021

Fixes #13

@jamadden
Copy link
Member

jamadden commented Mar 5, 2021

It’s good to remove the .travis.yml too

@cutz
Copy link
Contributor Author

cutz commented Mar 5, 2021

Well, making a bit of progress. Tests are failing due to the strict IRO checking. I'm not 100% sure how to interpret the output here. Are these issues in zope.publisher land?

Issue #16

@cutz
Copy link
Contributor Author

cutz commented Mar 5, 2021

Not sure why coveralls is reporting no coverage now.

Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why coveralls is reporting no coverage now.

Probably because there's a setting that needs added in .coveragerc, relative_files = true. See nti.webhooks for an example and comment.

.github/workflows/tests.yml Show resolved Hide resolved
@cutz cutz merged commit 1720992 into master Mar 11, 2021
@cutz cutz deleted the gh-actions branch March 11, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup GH Actions
2 participants