Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InternalError: too much recursion for ds004504 #2999

Open
effigies opened this issue Feb 26, 2024 · 5 comments
Open

InternalError: too much recursion for ds004504 #2999

effigies opened this issue Feb 26, 2024 · 5 comments
Labels

Comments

@effigies
Copy link
Contributor

What went wrong?

Reported by user: ds004504 is inaccessible. Going to https://openneuro.org/datasets/ds004504 results in an "InternalError: too much recursion" error.

Expected behavior

Show dataset.

How to reproduce

Desktop

  • OS:
  • Browser:
  • Version:

Phone

  • Device:
  • OS:
  • Browser:
  • Version:

Additional information

image

image

@effigies effigies added the bug label Feb 26, 2024
@rwblair
Copy link
Collaborator

rwblair commented Feb 26, 2024

I'm leaning towards the something in the dataset_description.json not playing well with the markdown to jsx library:
quantizor/markdown-to-jsx#496
quantizor/markdown-to-jsx#473

@rwblair
Copy link
Collaborator

rwblair commented Feb 26, 2024

Re that second link, ds004504 README has a lot of consecutive spaces in it.

@effigies
Copy link
Contributor Author

@effigies
Copy link
Contributor Author

Opened #3000 to do the minimal fix. Not sure if it would be better to switch to another library that doesn't implement a CFL with regular expressions.

@nellh
Copy link
Contributor

nellh commented Feb 29, 2024

I implemented the switch to react-markdown in #3009. This is closer to the GitHub markdown feature set anyways that we are aiming for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants