Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Server 4 Update #2866

Merged
merged 14 commits into from
Sep 7, 2023
Merged

Apollo Server 4 Update #2866

merged 14 commits into from
Sep 7, 2023

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jul 27, 2023

This brings OpenNeuro's API server up to date with the latest release of Apollo server. Apollo server 2 and 3 are approaching end of life.

  • Updates to TypeScript 5.1.6 (required for Apollo 4)
  • Node 18.17.0 and TypeScript 5.1.6
  • Disables GraphQL subscriptions as these are no longer natively supported and not used by much of the post redesign OpenNeuro site.

Has a few known issues before ready to merge:

  • Comments throw an error on deletion
  • Creating the first snapshot redirects properly but page must be reloaded before the dataset can be published due to the missing subscription update

As there's only a few issues to fix, this should be ready once the subscriptions are fixed.

@nellh nellh marked this pull request as ready for review September 7, 2023 00:16
@nellh nellh merged commit e9a3bf2 into master Sep 7, 2023
2 checks passed
@nellh nellh deleted the apollo-server-4 branch September 7, 2023 17:23
@nellh nellh mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant