From 71119ec695727e7279226e6953803c08a2dd586d Mon Sep 17 00:00:00 2001
From: Nell Hardcastle <nell@dev-nell.com>
Date: Thu, 7 Sep 2023 21:09:22 -0700
Subject: [PATCH] fix: TypeScript upgrade build fixes for 5.1.0

---
 .pnp.cjs                                               |  8 ++++----
 .../scripts/dataset/mutations/delete-dataset-form.jsx  |  1 -
 .../src/scripts/dataset/mutations/metadata-form.jsx    |  1 -
 .../src/scripts/search/__helpers__/search-render.tsx   |  1 -
 packages/openneuro-cli/src/transferKey.js              |  1 -
 packages/openneuro-components/package.json             |  2 +-
 .../src/activity-slider/ActivitySlider.tsx             |  1 +
 yarn.lock                                              | 10 +++++-----
 8 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/.pnp.cjs b/.pnp.cjs
index 37830735b7..3f74da977d 100755
--- a/.pnp.cjs
+++ b/.pnp.cjs
@@ -4972,7 +4972,7 @@ function $$SETUP_STATE(hydrateRuntimeState, basePath) {
             ["prop-types", "npm:15.7.2"],\
             ["react", "npm:17.0.2"],\
             ["react-dom", "virtual:bb4ed02b339ed801b02d2ec15b42a5aa7b1afdaf44119aefaab128a59d6e16cc6018880c169f24bf2107550e914562ee9e1780db01a12e1bc3c492ad0a049c36#npm:17.0.2"],\
-            ["react-multi-carousel", "npm:2.6.5"],\
+            ["react-multi-carousel", "npm:2.8.4"],\
             ["react-router-dom", "virtual:bb4ed02b339ed801b02d2ec15b42a5aa7b1afdaf44119aefaab128a59d6e16cc6018880c169f24bf2107550e914562ee9e1780db01a12e1bc3c492ad0a049c36#npm:6.3.0"],\
             ["react-usestateref", "virtual:bb4ed02b339ed801b02d2ec15b42a5aa7b1afdaf44119aefaab128a59d6e16cc6018880c169f24bf2107550e914562ee9e1780db01a12e1bc3c492ad0a049c36#npm:1.0.5"],\
             ["sass", "npm:1.42.1"],\
@@ -19245,10 +19245,10 @@ function $$SETUP_STATE(hydrateRuntimeState, basePath) {
         }]\
       ]],\
       ["react-multi-carousel", [\
-        ["npm:2.6.5", {\
-          "packageLocation": "./.yarn/cache/react-multi-carousel-npm-2.6.5-037d977936-2ba44029a8.zip/node_modules/react-multi-carousel/",\
+        ["npm:2.8.4", {\
+          "packageLocation": "./.yarn/cache/react-multi-carousel-npm-2.8.4-e0619af128-ed4d95630f.zip/node_modules/react-multi-carousel/",\
           "packageDependencies": [\
-            ["react-multi-carousel", "npm:2.6.5"],\
+            ["react-multi-carousel", "npm:2.8.4"],\
             ["react", "npm:17.0.2"]\
           ],\
           "linkType": "HARD"\
diff --git a/packages/openneuro-app/src/scripts/dataset/mutations/delete-dataset-form.jsx b/packages/openneuro-app/src/scripts/dataset/mutations/delete-dataset-form.jsx
index 32ffbccc54..75c75e7473 100644
--- a/packages/openneuro-app/src/scripts/dataset/mutations/delete-dataset-form.jsx
+++ b/packages/openneuro-app/src/scripts/dataset/mutations/delete-dataset-form.jsx
@@ -57,7 +57,6 @@ const DeleteDatasetForm = ({ values, onChange, hasEdit }) => (
         },
         i,
       ) => (
-        // @ts-expect-error
         <FieldComponent
           name={key}
           label={label}
diff --git a/packages/openneuro-app/src/scripts/dataset/mutations/metadata-form.jsx b/packages/openneuro-app/src/scripts/dataset/mutations/metadata-form.jsx
index 1fef120dd5..d3013d75b0 100644
--- a/packages/openneuro-app/src/scripts/dataset/mutations/metadata-form.jsx
+++ b/packages/openneuro-app/src/scripts/dataset/mutations/metadata-form.jsx
@@ -357,7 +357,6 @@ const MetadataForm = ({
           },
           i,
         ) => (
-          // @ts-expect-error
           <FieldComponent
             name={key}
             label={label}
diff --git a/packages/openneuro-app/src/scripts/search/__helpers__/search-render.tsx b/packages/openneuro-app/src/scripts/search/__helpers__/search-render.tsx
index 5427ecc64c..d20678d645 100644
--- a/packages/openneuro-app/src/scripts/search/__helpers__/search-render.tsx
+++ b/packages/openneuro-app/src/scripts/search/__helpers__/search-render.tsx
@@ -1,7 +1,6 @@
 import React from 'react'
 import { SearchParamsCtx } from '../search-params-ctx'
 import { render } from '@testing-library/react'
-import { queries } from '@testing-library/dom'
 
 /**
  * Render with SearchParamsCtx state
diff --git a/packages/openneuro-cli/src/transferKey.js b/packages/openneuro-cli/src/transferKey.js
index 85750a6082..7968a04062 100644
--- a/packages/openneuro-cli/src/transferKey.js
+++ b/packages/openneuro-cli/src/transferKey.js
@@ -58,7 +58,6 @@ export async function retrieveKey(state, key, file) {
     const response = await fetch(request)
     if (response.status === 200) {
       const writable = createWriteStream(file)
-      // @ts-expect-error
       const readable = await response.readable()
       readable.pipe(writable)
       await once(readable, 'close')
diff --git a/packages/openneuro-components/package.json b/packages/openneuro-components/package.json
index 8538584f43..4133649583 100644
--- a/packages/openneuro-components/package.json
+++ b/packages/openneuro-components/package.json
@@ -25,7 +25,7 @@
     "prop-types": "^15.7.2",
     "react": "^17.0.1",
     "react-dom": "^17.0.2",
-    "react-multi-carousel": "^2.6.3",
+    "react-multi-carousel": "^2.8.4",
     "react-router-dom": "6.3.0",
     "react-usestateref": "^1.0.5"
   },
diff --git a/packages/openneuro-components/src/activity-slider/ActivitySlider.tsx b/packages/openneuro-components/src/activity-slider/ActivitySlider.tsx
index c902ab2a83..82053ad3ff 100644
--- a/packages/openneuro-components/src/activity-slider/ActivitySlider.tsx
+++ b/packages/openneuro-components/src/activity-slider/ActivitySlider.tsx
@@ -40,6 +40,7 @@ export const ActivitySlider = ({
   return (
     <div className={'activity-slider' + ' ' + className}>
       <h3>{slideHeader}</h3>
+      {/* @ts-expect-error */}
       <Carousel
         infinite={infinite}
         keyBoardControl={keyBoardControl}
diff --git a/yarn.lock b/yarn.lock
index 8853279dc8..6fa829f1c2 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -4135,7 +4135,7 @@ __metadata:
     prop-types: ^15.7.2
     react: ^17.0.1
     react-dom: ^17.0.2
-    react-multi-carousel: ^2.6.3
+    react-multi-carousel: ^2.8.4
     react-router-dom: 6.3.0
     react-usestateref: ^1.0.5
     sass: ^1.32.8
@@ -16508,10 +16508,10 @@ fsevents@~2.3.2:
   languageName: node
   linkType: hard
 
-"react-multi-carousel@npm:^2.6.3":
-  version: 2.6.5
-  resolution: "react-multi-carousel@npm:2.6.5"
-  checksum: 2ba44029a8c197320e5e536ee341a5bff492761de6a82e7335a719a11bc56b1d8fee2aa0854de2bcad67e819a2cbd7bb15ebf6ae1db9caf5d056b3f04e917806
+"react-multi-carousel@npm:^2.8.4":
+  version: 2.8.4
+  resolution: "react-multi-carousel@npm:2.8.4"
+  checksum: ed4d95630f2a6c144f630874cc445e94678a9cfa4f1a2ebffe15b4f8317d3210f5141b64646f5b64689c18d11ebaeed008190ae864d7ee55193f12a9f1857542
   languageName: node
   linkType: hard