Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeScript upgrade build fixes for 5.1.0 #2888

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix: TypeScript upgrade build fixes for 5.1.0 #2888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .pnp.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/openneuro-app/src/scripts/dataset/mutations/delete-dataset-form.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ const DeleteDatasetForm = ({ values, onChange, hasEdit }) => (
},
i,
) => (
// @ts-expect-error
<FieldComponent
name={key}
label={label}
Expand Down
1 change: 0 additions & 1 deletion packages/openneuro-app/src/scripts/dataset/mutations/metadata-form.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ const MetadataForm = ({
},
i,
) => (
// @ts-expect-error
<FieldComponent
name={key}
label={label}
Expand Down
1 change: 0 additions & 1 deletion packages/openneuro-app/src/scripts/search/__helpers__/search-render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React from 'react'
import { SearchParamsCtx } from '../search-params-ctx'
import { render } from '@testing-library/react'
import { queries } from '@testing-library/dom'

/**
* Render with SearchParamsCtx state
Expand Down
1 change: 0 additions & 1 deletion packages/openneuro-cli/src/transferKey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export async function retrieveKey(state, key, file) {
const response = await fetch(request)
if (response.status === 200) {
const writable = createWriteStream(file)
// @ts-expect-error
const readable = await response.readable()
readable.pipe(writable)
await once(readable, 'close')
Expand Down
2 changes: 1 addition & 1 deletion packages/openneuro-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"prop-types": "^15.7.2",
"react": "^17.0.1",
"react-dom": "^17.0.2",
"react-multi-carousel": "^2.6.3",
"react-multi-carousel": "^2.8.4",
"react-router-dom": "6.3.0",
"react-usestateref": "^1.0.5"
},
Expand Down
1 change: 1 addition & 0 deletions packages/openneuro-components/src/activity-slider/ActivitySlider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const ActivitySlider = ({
return (
<div className={'activity-slider' + ' ' + className}>
<h3>{slideHeader}</h3>
{/* @ts-expect-error */}
<Carousel
infinite={infinite}
keyBoardControl={keyBoardControl}
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4135,7 +4135,7 @@ __metadata:
prop-types: ^15.7.2
react: ^17.0.1
react-dom: ^17.0.2
react-multi-carousel: ^2.6.3
react-multi-carousel: ^2.8.4
react-router-dom: 6.3.0
react-usestateref: ^1.0.5
sass: ^1.32.8
Expand Down Expand Up @@ -16508,10 +16508,10 @@ fsevents@~2.3.2:
languageName: node
linkType: hard

"react-multi-carousel@npm:^2.6.3":
version: 2.6.5
resolution: "react-multi-carousel@npm:2.6.5"
checksum: 2ba44029a8c197320e5e536ee341a5bff492761de6a82e7335a719a11bc56b1d8fee2aa0854de2bcad67e819a2cbd7bb15ebf6ae1db9caf5d056b3f04e917806
"react-multi-carousel@npm:^2.8.4":
version: 2.8.4
resolution: "react-multi-carousel@npm:2.8.4"
checksum: ed4d95630f2a6c144f630874cc445e94678a9cfa4f1a2ebffe15b4f8317d3210f5141b64646f5b64689c18d11ebaeed008190ae864d7ee55193f12a9f1857542
languageName: node
linkType: hard

Expand Down