Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate server code to TypeScript #2931

Merged
merged 13 commits into from
Nov 2, 2023
Merged

Migrate server code to TypeScript #2931

merged 13 commits into from
Nov 2, 2023

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Oct 27, 2023

Completing our migration to typescript for the server package.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2931 (359570e) into master (2c46b00) will increase coverage by 0.05%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #2931      +/-   ##
==========================================
+ Coverage   86.93%   86.98%   +0.05%     
==========================================
  Files         383      379       -4     
  Lines       65030    64914     -116     
  Branches     1170     1171       +1     
==========================================
- Hits        56534    56468      -66     
+ Misses       8490     8444      -46     
+ Partials        6        2       -4     
Files Coverage Δ
packages/openneuro-server/src/__mocks__/config.ts 100.00% <ø> (ø)
packages/openneuro-server/src/config.ts 100.00% <ø> (ø)
packages/openneuro-server/src/datalad/analytics.ts 25.00% <ø> (ø)
packages/openneuro-server/src/datalad/changelog.ts 83.33% <100.00%> (ø)
packages/openneuro-server/src/datalad/dataset.ts 41.73% <100.00%> (ø)
...ckages/openneuro-server/src/datalad/description.ts 74.32% <100.00%> (ø)
...ackages/openneuro-server/src/datalad/pagination.ts 93.40% <ø> (ø)
packages/openneuro-server/src/datalad/readme.ts 28.20% <ø> (ø)
...enneuro-server/src/elasticsearch/elastic-client.ts 100.00% <100.00%> (ø)
...nneuro-server/src/elasticsearch/reindex-dataset.ts 77.50% <100.00%> (ø)
... and 26 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nellh nellh marked this pull request as ready for review November 2, 2023 16:13
@nellh nellh merged commit 0095eb6 into master Nov 2, 2023
6 of 7 checks passed
@nellh nellh deleted the server/typescript-fixes branch November 2, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants