feat(dataset): Annex TSV files in phenotype directory #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
changed the title
|
Also not positive of the convention for tagging PRs... |
Codecov Report
@@ Coverage Diff @@
## master #2940 +/- ##
=======================================
Coverage 65.06% 65.06%
=======================================
Files 378 378
Lines 24029 24029
Branches 861 861
=======================================
Hits 15635 15635
Misses 8394 8394
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Squishymedia was using Conventional Commits and I've mostly kept going with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
phenotype/*.tsvto the annex by default.Should we (and how should we) inject this into legacy datasets?
I couldn't find a place where we test that expected files get annexed or not. If a test is needed, I'll need a little guidance of what to use as a model.