-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clickthrough agreement for downloads #2947
Conversation
…t has not been accepted
… across components
…d agreement state
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
+ Coverage 64.89% 65.08% +0.19%
==========================================
Files 378 378
Lines 24230 24309 +79
Branches 868 884 +16
==========================================
+ Hits 15723 15822 +99
+ Misses 8507 8487 -20 ☔ View full report in Codecov by Sentry. |
Can this be pushed to staging for an interactive view? |
307edd8
to
ec35409
Compare
It's on staging now. I'm planning on making a couple minor fixes once I have the text as far as styling. The button gets pushed off the screen on mobile sometimes. Spacing can be a little off where the button gets cut off at some screen sizes. Let me know if you see other issues. |
When the button is visible, it can be pushed down a bit and get cropped by the bottom of the window: Also, the "I Agree" seems like it should have a non-breaking space or for the text to be centered in the button. Would it be possible to allow the text to scroll when the window gets too narrow? I assume the goal of not increasing the height is to prevent the page contents from being covered. |
Overall this works smoothly. Attempting to browse and search works fine, but attempting to view a file or a download page is blocked until I press the button, at which point the buttons/tab are instantly made visible. |
This looks good as is, but what about instead of hiding the |
…n accepted This replaces the behavior of hiding the button
This just needs text content to be ready for review.
The agreement is a floating banner on the bottom of the browser window. It disappears once you have agreed and enables download/view file links. Download pages redirect to the dataset page if the agreement has not been accepted. The agreement is persisted in local storage and shown again if the user is downloading from another browser or clears local storage.