FIX: Display metadata lists as unordered lists #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2985 +/- ##
==========================================
+ Coverage 65.15% 65.18% +0.02%
==========================================
Files 380 381 +1
Lines 24494 24527 +33
Branches 879 882 +3
==========================================
+ Hits 15960 15988 +28
- Misses 8534 8539 +5 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
fix/list-metadata-lists
branch
from
6714af2
to
89cc1c3
Compare
nellh
force-pushed
the
fix/list-metadata-lists
branch
from
89cc1c3
to
c2be48a
Compare
|
Thanks for making it actually work. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2984. Needs tests, but I think this is about what we want, pulling what I could find from
packages/openneuro-app/src/scripts/dataset/fragments/edit-description-list.jsx.I haven't got a local build working, so I'm not sure if this is quite right.