Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 30 second timeout to dataset resolver #3012

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Mar 5, 2024

This avoids aggregate queries (search) from hanging forever if one result cannot be loaded in the 30 second deadline.

Prevents search from hanging indefinitely when one dataset cannot be loaded
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 65.28%. Comparing base (5495968) to head (f71d40f).

Files Patch % Lines
...kages/openneuro-server/src/utils/promiseTimeout.ts 93.54% 2 Missing ⚠️
.../openneuro-server/src/graphql/resolvers/dataset.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3012      +/-   ##
==========================================
+ Coverage   65.24%   65.28%   +0.04%     
==========================================
  Files         382      384       +2     
  Lines       24610    24648      +38     
  Branches      885      891       +6     
==========================================
+ Hits        16056    16092      +36     
- Misses       8554     8556       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit e410cdd into master Mar 11, 2024
8 checks passed
@nellh nellh deleted the dataset-query-timeout branch March 11, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant