Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Recommend "provider = generic" in .gitconfig #3025

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Apr 5, 2024

At least when credential.credentialStore == secretservice, failing to include this produces a large number of sections like:

[credential "https://openneuro.org/git/0/ds002278"]
provider = generic

Adding this prevents that duplication. I am not positive that this has no knock-on effects.

At least when credential.credentialStore == secretservice, failing to
include this produces a large number of sections like:

```cfg
[credential "https://openneuro.org/git/0/ds002278"]
provider = generic
```

Adding this prevents that duplication. I am not positive that this has
no knock-on effects.
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (d96e63d) to head (4719417).
Report is 3 commits behind head on master.

❗ Current head 4719417 differs from pull request most recent head 59f2b7e. Consider uploading reports for the commit 59f2b7e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
- Coverage   65.31%   64.41%   -0.90%     
==========================================
  Files         384      398      +14     
  Lines       24670    25687    +1017     
  Branches      895      929      +34     
==========================================
+ Hits        16112    16546     +434     
- Misses       8558     9141     +583     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh
Copy link
Contributor

nellh commented Apr 9, 2024

I added an explanation of what the provider field is useful for so that it can be searched for if someone has this problem. It doesn't look like it will cause any issues.

@nellh nellh merged commit 2f91577 into OpenNeuroOrg:master Apr 9, 2024
8 of 9 checks passed
@effigies effigies deleted the doc/git-credential-provider branch April 9, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants