Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ElasticSearch features from worker (APM and logging) #3115

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Aug 7, 2024

This consolidates validation error logging with container logs and drops all dependencies on ElasticSearch from the worker.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.66%. Comparing base (6ae55a9) to head (55d7451).

Files Patch % Lines
...ervices/datalad/datalad_service/tasks/validator.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
+ Coverage   42.64%   42.66%   +0.01%     
==========================================
  Files         594      593       -1     
  Lines       37874    37856      -18     
  Branches     1098     1098              
==========================================
- Hits        16151    16150       -1     
+ Misses      21516    21499      -17     
  Partials      207      207              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 3d8ed92 into master Aug 7, 2024
8 of 11 checks passed
@nellh nellh deleted the drop-apm-worker branch August 7, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant