Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Replace Elastic APM with Sentry #3119

Merged
merged 6 commits into from
Aug 12, 2024
Merged

refactor(app): Replace Elastic APM with Sentry #3119

merged 6 commits into from
Aug 12, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Aug 10, 2024

Tried out a few options but Sentry is compatible with Deno and avoids the need to manage APM along with search.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 4.08163% with 47 lines in your changes missing coverage. Please review.

Project coverage is 42.60%. Comparing base (398051a) to head (4575c31).
Report is 2 commits behind head on master.

Files Patch % Lines
packages/openneuro-app/src/scripts/sentry.ts 0.00% 19 Missing and 1 partial ⚠️
packages/openneuro-app/src/scripts/config.ts 0.00% 8 Missing ⚠️
...pp/src/scripts/dataset/download/download-native.js 12.50% 7 Missing ⚠️
...es/openneuro-app/src/scripts/uploader/uploader.jsx 0.00% 3 Missing and 1 partial ⚠️
...ro-app/src/scripts/pages/front-page/front-page.tsx 0.00% 3 Missing ⚠️
...penneuro-app/src/scripts/dataset/dataset-query.jsx 0.00% 2 Missing ⚠️
packages/openneuro-app/src/client.jsx 0.00% 1 Missing ⚠️
...openneuro-app/src/scripts/errors/errorBoundary.jsx 50.00% 1 Missing ⚠️
packages/openneuro-server/src/handlers/config.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3119      +/-   ##
==========================================
- Coverage   42.66%   42.60%   -0.06%     
==========================================
  Files         593      592       -1     
  Lines       37855    37811      -44     
  Branches     1098     1094       -4     
==========================================
- Hits        16149    16111      -38     
+ Misses      21499    21492       -7     
- Partials      207      208       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 464f685 into master Aug 12, 2024
6 of 11 checks passed
@nellh nellh deleted the app-drop-apm branch August 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant